Put fatal messages at the top in the primer comment #6744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 |
Pull Request Test Coverage Report for Build 2405661611
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Ref. #5364 (comment)
Example message after this change:
🤖 Effect of this PR on checked open source code: 🤖
Effect on astroid:
The following fatal messages are now emitted: 💣💥
Fatal error while checking 'tests/.pylint_primer_tests/PyCQA/astroid/astroid/interpreter/objectmodel.py'. Please open an issue in our bug tracker so we address this. There is a pre-filled template that you can use in '/Users/daniel/Library/Caches/pylint/pylint-crash-2022-05-29-17.txt'.
Please check your changes on the following file:
https://github.com/PyCQA/astroid/blob/main/astroid/interpreter/objectmodel.py#L1
Fatal error while checking 'tests/.pylint_primer_tests/PyCQA/astroid/astroid/nodes/node_classes.py'. Please open an issue in our bug tracker so we address this. There is a pre-filled template that you can use in '/Users/daniel/Library/Caches/pylint/pylint-crash-2022-05-29-17.txt'.
Please check your changes on the following file:
https://github.com/PyCQA/astroid/blob/main/astroid/nodes/node_classes.py#L1
The following messages are now emitted:
Import "import sys" should be placed at the top of the module
https://github.com/PyCQA/astroid/blob/main/astroid/interpreter/_import/util.py#L5
Import "from functools import lru_cache" should be placed at the top of the module
https://github.com/PyCQA/astroid/blob/main/astroid/interpreter/_import/util.py#L6
The following messages are no longer emitted:
Missing class docstring
https://github.com/PyCQA/astroid/blob/main/astroid/interpreter/objectmodel.py#L122
Missing function or method docstring
https://github.com/PyCQA/astroid/blob/main/astroid/interpreter/objectmodel.py#L123