Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out astroid errors from the bot comment #6773

Merged

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
🔨 Refactoring

Description

See potential for confusion like at #6769 (comment). Just point people to the GitHub Actions warning if they wan't to look into it, but mostly just advising chilling out.
Refs #5364

@coveralls
Copy link

coveralls commented May 31, 2022

Pull Request Test Coverage Report for Build 2415407260

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.515%

Totals Coverage Status
Change from base Build 2414895377: 0.0%
Covered Lines: 16229
Relevant Lines: 16991

💛 - Coveralls

Copy link
Member Author

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[removed] -- was using new web editor!

@jacobtylerwalls jacobtylerwalls merged commit 731df04 into pylint-dev:main May 31, 2022
@jacobtylerwalls jacobtylerwalls deleted the clarify-astroid-errors branch May 31, 2022 14:19
@github-actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on pandas:
4 error(s) were found stemming from the astroid library. This is unlikely to have been caused by your changes. A GitHub Actions warning links directly to the crash report template. Please open an issue against astroid if one does not exist already.

The following messages are no longer emitted:

  1. astroid-error:
    tests/.pylint_primer_tests/pandas-dev/pandas/pandas/tests/io/test_common.py: Fatal error while checking 'tests/.pylint_primer_tests/pandas-dev/pandas/pandas/tests/io/test_common.py'. Please open an issue in our bug tracker so we address this. There is a pre-filled template that you can use in '/home/runner/.cache/pylint/pylint-crash-2022-05-31-13.txt'.
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/test_common.py#L1
  2. astroid-error:
    tests/.pylint_primer_tests/pandas-dev/pandas/pandas/tests/io/sas/test_sas7bdat.py: Fatal error while checking 'tests/.pylint_primer_tests/pandas-dev/pandas/pandas/tests/io/sas/test_sas7bdat.py'. Please open an issue in our bug tracker so we address this. There is a pre-filled template that you can use in '/home/runner/.cache/pylint/pylint-crash-2022-05-31-13.txt'.
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/sas/test_sas7bdat.py#L1
  3. astroid-error:
    tests/.pylint_primer_tests/pandas-dev/pandas/pandas/tests/io/excel/test_readers.py: Fatal error while checking 'tests/.pylint_primer_tests/pandas-dev/pandas/pandas/tests/io/excel/test_readers.py'. Please open an issue in our bug tracker so we address this. There is a pre-filled template that you can use in '/home/runner/.cache/pylint/pylint-crash-2022-05-31-13.txt'.
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/excel/test_readers.py#L1
  4. astroid-error:
    tests/.pylint_primer_tests/pandas-dev/pandas/pandas/tests/io/pytables/test_read.py: Fatal error while checking 'tests/.pylint_primer_tests/pandas-dev/pandas/pandas/tests/io/pytables/test_read.py'. Please open an issue in our bug tracker so we address this. There is a pre-filled template that you can use in '/home/runner/.cache/pylint/pylint-crash-2022-05-31-13.txt'.
    https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/pytables/test_read.py#L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants