Partial typing of `imports.py` #6982

DanielNoord · 2022-06-20T07:10:57Z

Add yourself to CONTRIBUTORS if you are a new contributor.
Write a good description on what the PR does.

Type of Changes

	Type
✓	🔨 Refactoring

Description

coveralls · 2022-06-20T07:28:18Z

Pull Request Test Coverage Report for Build 2663433329

38 of 38 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 95.372%

Totals
Change from base Build 2663295382:	0.001%
Covered Lines:	16797
Relevant Lines:	17612

💛 - Coveralls

Pierre-Sassoulas

Maybe we could create an alias for nodes.Import | nodes.ImportFrom ?

Pierre-Sassoulas · 2022-06-20T07:31:08Z

pylint/checkers/imports.py

+        node: nodes.If
+        | nodes.Expr
+        | nodes.Comprehension
+        | nodes.IfExp
+        | nodes.Assign
+        | nodes.AssignAttr
+        | nodes.TryExcept
+        | nodes.TryFinally,


If this can be everything except an import node it could also be a classDef or a lot of things, right ? Maybe NodeNG would make sense ?

See L577. I thought I would be explicit just like we normally are for visit_ methods.

That said L622 shows that L602 is incorrect.

I'm drafting as I'd like to fix that in this PR.

DanielNoord · 2022-06-20T07:35:59Z

Maybe we could create an alias for nodes.Import | nodes.ImportFrom ?

There is mixins.ImportFrom in astroid but since that doesn't inherit from NodeNG it doesn't really work.

Let's put pylint-dev/astroid#1633 in 2.12 and do the necessary refactoring as well. Marc just gave his thumbs up for the issue so I think he is also okay with my proposal to start inheriting from NodeNG for the mixins.

TLDR: Drafting as we need astroid 2.12 with additional changes + a fix for visit_functiondef in this module.

Pierre-Sassoulas

If mypy is happy, I'm happy too 😄

github-actions · 2022-07-13T13:06:22Z

🤖 Effect of this PR on checked open source code: 🤖

Effect on django:
The following messages are now emitted:

invalid-name:
Attribute name "Meta" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern
https://github.com/django/django/blob/main/django/db/models/base.py#L360
no-value-for-parameter:
No value for argument 'cls' in classmethod call
https://github.com/django/django/blob/main/django/utils/deconstruct.py#L17

The following messages are no longer emitted:

no-member:
Instance of 'BaseManager' has no '_constructor_args' member
https://github.com/django/django/blob/main/django/db/models/manager.py#L75
no-member:
Instance of 'BaseManager' has no '_constructor_args' member
https://github.com/django/django/blob/main/django/db/models/manager.py#L76
no-member:
Instance of 'BaseManager' has no '_constructor_args' member
https://github.com/django/django/blob/main/django/db/models/manager.py#L169

Effect on pandas:
The following messages are now emitted:

redefined-variable-type:
Redefinition of columns type from pandas.core.indexes.range.RangeIndex to pandas.core.indexes.base.Index
https://github.com/pandas-dev/pandas/blob/main/pandas/core/internals/construction.py#L860
redefined-variable-type:
Redefinition of new_target type from pandas.core.indexes.category.CategoricalIndex to pandas.core.indexes.base.Index
https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/category.py#L455

The following messages are no longer emitted:

redefined-variable-type:
Redefinition of index type from pandas.core.indexes.base.Index to pandas.core.indexes.range.RangeIndex
https://github.com/pandas-dev/pandas/blob/main/pandas/core/series.py#L456
redefined-variable-type:
Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.range.RangeIndex
https://github.com/pandas-dev/pandas/blob/main/pandas/core/internals/construction.py#L850
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/floating.py#L141
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/floating.py#L148
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/integer.py#L160
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/integer.py#L167
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/integer.py#L174
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/integer.py#L181
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/integer.py#L188
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/integer.py#L195
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/integer.py#L202
empty-docstring:
Empty class docstring
https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/integer.py#L209
redefined-variable-type:
Redefinition of new_target type from pandas.core.indexes.base.Index to pandas.core.indexes.category.CategoricalIndex
https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/category.py#L442

Effect on pytest:
The following messages are now emitted:

consider-using-dict-items:
Consider iterating with .items()
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/reports.py#L513
redefined-variable-type:
Redefinition of ret type from str to _pytest.config.ExitCode
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/pytester.py#L1145
redefined-variable-type:
Redefinition of ret type from int to _pytest.config.ExitCode
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/pytester.py#L1429
no-name-in-module:
No name 'PytestReturnNotNoneWarning' in module '_pytest.warning_types'
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/python.py#L80
redefined-variable-type:
Redefinition of importhook type from _distutils_hack.DistutilsMetaFinder to _pytest.assertion.DummyRewriteHook
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/assertion/__init__.py#L69

Effect on sentry:
The following messages are now emitted:

redefined-variable-type:
Redefinition of culprit type from str to list
https://github.com/getsentry/sentry/blob/master/src/sentry/culprit.py#L38
consider-iterating-dictionary:
Consider iterating the dictionary directly instead of calling .keys()
https://github.com/getsentry/sentry/blob/master/src/sentry/web/frontend/error_page_embed.py#L138
no-member:
Instance of 'module' has no 'file' member
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/base.py#L37

The following messages are no longer emitted:

unused-import:
Unused ActorTuple imported from sentry.models
https://github.com/getsentry/sentry/blob/master/src/sentry/models/projectownership.py#L9
not-callable:
fmt is not callable
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/snuba.py#L1316
no-member:
Instance of 'str' has no 'objects' member
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/snuba.py#L1316
redefined-variable-type:
Redefinition of initials type from str to django.utils.safestring.SafeString
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/avatar.py#L77

This comment was generated for commit 58e2ab3

DanielNoord added the typing label Jun 20, 2022

DanielNoord mentioned this pull request Jun 20, 2022

Correct typing of relative_to_absolute_name pylint-dev/astroid#1637

Merged

1 task

Pierre-Sassoulas reviewed Jun 20, 2022

View reviewed changes

DanielNoord marked this pull request as draft June 20, 2022 07:33

DanielNoord added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Jun 20, 2022

This comment has been minimized.

Sign in to view

DanielNoord added 2 commits July 13, 2022 14:14

Partial typing of imports.py

73e99c0

Update typing

58e2ab3

DanielNoord force-pushed the typing-checkers-2 branch from d2aacb2 to 58e2ab3 Compare July 13, 2022 12:32

DanielNoord removed the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Jul 13, 2022

DanielNoord requested a review from Pierre-Sassoulas July 13, 2022 12:37

DanielNoord marked this pull request as ready for review July 13, 2022 12:37

Pierre-Sassoulas approved these changes Jul 13, 2022

View reviewed changes

DanielNoord merged commit 65543fd into pylint-dev:main Jul 13, 2022

DanielNoord deleted the typing-checkers-2 branch July 13, 2022 12:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Partial typing of `imports.py` #6982

Partial typing of `imports.py` #6982

DanielNoord commented Jun 20, 2022

coveralls commented Jun 20, 2022 •

edited

Loading

Pierre-Sassoulas left a comment

Pierre-Sassoulas Jun 20, 2022

DanielNoord Jun 20, 2022

DanielNoord commented Jun 20, 2022

This comment has been minimized.

Pierre-Sassoulas left a comment

github-actions bot commented Jul 13, 2022

Partial typing of imports.py #6982

Partial typing of imports.py #6982

Conversation

DanielNoord commented Jun 20, 2022

Type of Changes

Description

coveralls commented Jun 20, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2663433329

💛 - Coveralls

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas Jun 20, 2022

Choose a reason for hiding this comment

DanielNoord Jun 20, 2022

Choose a reason for hiding this comment

DanielNoord commented Jun 20, 2022

This comment has been minimized.

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 13, 2022

Partial typing of `imports.py` #6982

Partial typing of `imports.py` #6982

coveralls commented Jun 20, 2022 •

edited

Loading