-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unsupported version checks for major 3.11 and 3.12 features #9792
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9792 +/- ##
==========================================
- Coverage 95.80% 95.79% -0.01%
==========================================
Files 174 174
Lines 18883 18906 +23
==========================================
+ Hits 18090 18111 +21
- Misses 793 795 +2
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea !
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want functional tests for these?
@@ -1 +1 @@ | |||
string = "\z" # [anomalous-backslash-in-string] | |||
string = "\z" # [syntax-error] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably move these then? As this will look weird in our documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the best solution is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add a details.rst
explaining that this is because of our CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should cover the new code with tests. Regarding the doc not raising the right message anymore, maybe we need run the CI for each supported interpreters and add skipif on the one that are not relevant (with the same configuration than for functional test min_pyver / max_pyver) ?
Will come back and add some tests.
I wouldn't object, but I'm not volunteering to work on it in the near term. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we're still missing some tests but I would be okay with merging already. This seems like a useful new feature.
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 390c3b4 |
Type of Changes
Description
Closes #9791