Allow for more elemwise torch functions using broadcast_tensor and vmap
#1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to add a test, but I want to get feedback on #1031 before continuing. |
Ch0ronomato
changed the title
broadcast_tensor and vmap
|
I'll fix the tests. |
ricardoV94
reviewed
Oct 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
==========================================
- Coverage 81.90% 81.89% -0.01%
==========================================
Files 182 182
Lines 47879 47887 +8
Branches 8620 8619 -1
==========================================
+ Hits 39214 39216 +2
- Misses 6492 6498 +6
Partials 2173 2173
|
ricardoV94
reviewed
Oct 15, 2024
ricardoV94
reviewed
Oct 15, 2024
added 2 commits
October 26, 2024 18:39
Ch0ronomato
commented
Oct 27, 2024
ricardoV94
reviewed
Oct 29, 2024
|
|
||
| def elemwise_fn(*inputs): | ||
| Elemwise._check_runtime_broadcast(node, inputs) | ||
| shaped_inputs = torch.broadcast_tensors(*inputs) |
There was a problem hiding this comment.
Nit: more precise name:
Suggested change
| shaped_inputs = torch.broadcast_tensors(*inputs) | |
| broadcasted_inputs = torch.broadcast_tensors(*inputs) |
Also needs to be changed below
Comment on lines
+28
to
+29
| # @todo: This will fail for anything that calls | ||
| # `.item()` |
There was a problem hiding this comment.
Remove todo, not something that should be addressed in this impl, but for specific Ops, so if anything should exist as a github issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the event the operator
Elemwiseis broadcasting over doesn't have a direct torch function, we can leveragevmapandbroadcast_tensorsto replicate the ufunc machinery.Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1032.org.readthedocs.build/en/1032/