-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement numba overload for POTRF, LAPACK cholesky routine #578
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
- Coverage 80.92% 80.88% -0.05%
==========================================
Files 162 162
Lines 46641 46690 +49
Branches 11399 11412 +13
==========================================
+ Hits 37746 37766 +20
- Misses 6667 6695 +28
- Partials 2228 2229 +1
|
a0b3c0a
to
69af4cc
Compare
Shall I squash or do you want to tidy up the git history? |
I think it can squash? I was trying to keep thing tidy as I went. Well actually I tried to rearrange things to be ever better but it made a huge mess and I had to nuke and restart my local branch. So let me know if you want more done, and I'll do it. I'm happy on my end. |
Description
Tests are failing on #577 for the numba overloaded cholesky routine and I realized we didn't have a real one, so here it is. Now fully compatible with all the scipy keyword arguments. In addition, it will no longer drop numba into object mode.
Related Issue
Checklist
Type of change