Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #210: Add scikit-learn plots to README. #307

Merged

Conversation

anevolbap
Copy link
Contributor

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (3026ab4) to head (0012952).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          21       21           
  Lines        1380     1380           
=======================================
  Hits         1064     1064           
  Misses        316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drbenvincent
Copy link
Collaborator

I started reviewing this, not noticing that it's a draft. I was getting some warnings when running generate_plots.ipynb locally, so I updated from main and now it seems to run ok without errors.

I think this is ready to merge, but I'll wait until I hear from you @anevolbap unless I'm missing something :)

@drbenvincent drbenvincent marked this pull request as ready for review March 14, 2024 13:21
@anevolbap
Copy link
Contributor Author

@drbenvincent, feel free to merge! The error is likely related to #259, which has already been merged.

@drbenvincent drbenvincent added the documentation Improvements or additions to documentation label Mar 24, 2024
@drbenvincent drbenvincent merged commit 00dc744 into pymc-labs:main Mar 24, 2024
10 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants