Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename argument data_df to data #162

Closed
ricardoV94 opened this issue Feb 17, 2023 · 4 comments
Closed

Rename argument data_df to data #162

ricardoV94 opened this issue Feb 17, 2023 · 4 comments
Labels
good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package maintenance MMM

Comments

@ricardoV94
Copy link
Contributor

data_df stands for data dataframe I assume, I think we can just call it data?

pymc-marketing/pymc_marketing/mmm/base.py

Line 35 in f264c21

data_df: pd.DataFrame,

@ricardoV94 ricardoV94 added the MMM label Feb 17, 2023
@ricardoV94
Copy link
Contributor Author

What do you think @juanitorduz?

@juanitorduz
Copy link
Collaborator

No blocker from my side... we just need to be consistent :)

@ricardoV94 ricardoV94 added good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package maintenance labels Feb 22, 2023
@michaelraczycki
Copy link
Contributor

I'd like to do this

@juanitorduz
Copy link
Collaborator

Go for it 😀

@michaelraczycki michaelraczycki mentioned this issue Mar 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package maintenance MMM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juanitorduz @ricardoV94 @michaelraczycki