-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMM data_df
param renamed to data
#186
MMM data_df
param renamed to data
#186
Conversation
Thanks @michaelraczycki ! Would you mind changing this as well in the example notebook https://pymc-marketing.readthedocs.io/en/stable/notebooks/mmm/mmm_example.html? Actually, I wonder if it could be better to not just change the base class but all the arguments in the mmm module where |
Sure, I can take care of that too. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@ricardoV94 what do suggest doing in the meantime as the tests are not running (in view of #189)? |
Tests should pass after rebasing from main |
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 18 18
Lines 973 973
=======================================
Hits 919 919
Misses 54 54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
contains renaming parameter from baseMMM from data_df to data requested in
issue #162 .