Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMM data_df param renamed to data #186

Merged
merged 6 commits into from
Mar 8, 2023

Conversation

michaelraczycki
Copy link
Contributor

contains renaming parameter from baseMMM from data_df to data requested in
issue #162 .

@juanitorduz
Copy link
Collaborator

juanitorduz commented Mar 6, 2023

Thanks @michaelraczycki ! Would you mind changing this as well in the example notebook https://pymc-marketing.readthedocs.io/en/stable/notebooks/mmm/mmm_example.html?

Actually, I wonder if it could be better to not just change the base class but all the arguments in the mmm module where data_df appears:

image

@michaelraczycki
Copy link
Contributor Author

Sure, I can take care of that too.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz
Copy link
Collaborator

@ricardoV94 what do suggest doing in the meantime as the tests are not running (in view of #189)?

@ricardoV94
Copy link
Contributor

Tests should pass after rebasing from main

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #186 (f2f01bc) into main (d49b0b2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          18       18           
  Lines         973      973           
=======================================
  Hits          919      919           
  Misses         54       54           
Impacted Files Coverage Δ
pymc_marketing/mmm/base.py 95.00% <100.00%> (ø)
pymc_marketing/mmm/delayed_saturated_mmm.py 91.66% <100.00%> (ø)
pymc_marketing/mmm/preprocessing.py 100.00% <100.00%> (ø)
pymc_marketing/mmm/validating.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ricardoV94 ricardoV94 merged commit e4e05e0 into pymc-labs:main Mar 8, 2023
@ricardoV94 ricardoV94 changed the title Renaming base mmm param MMM data_df param renamed to data Mar 8, 2023
michaelraczycki added a commit to michaelraczycki/pymc-marketing that referenced this pull request Apr 6, 2023
@michaelraczycki michaelraczycki deleted the renaming_baseMMM_param branch June 27, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants