Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename models folder #520

Closed
ricardoV94 opened this issue Feb 8, 2024 · 7 comments · Fixed by #621
Closed

Rename models folder #520

ricardoV94 opened this issue Feb 8, 2024 · 7 comments · Fixed by #621
Labels
good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package

Comments

@ricardoV94
Copy link
Contributor

https://github.com/pymc-labs/pymc-marketing/tree/main/models

@wd60622
Copy link
Contributor

wd60622 commented Feb 19, 2024

Isn't this used for one of the notebooks?

@ricardoV94
Copy link
Contributor Author

Which notebook? Should be in datasets if needed but is it needed?

@wd60622
Copy link
Contributor

wd60622 commented Feb 20, 2024

@ricardoV94
Copy link
Contributor Author

Should go here then no? It's where we save other data for examples

https://github.com/pymc-labs/pymc-marketing/tree/main/datasets

And maybe have a better name?

@wd60622
Copy link
Contributor

wd60622 commented Feb 20, 2024

Should go here then no? It's where we save other data for examples

Yeah, if the notebooks are to be reproducible from a cloned repo. Might be better to use pathlib.Path in the notebook(s) as well

And maybe have a better name?

I'm not good at naming 😆 How about data? Model = data, datasets = data.

@ricardoV94
Copy link
Contributor Author

ricardoV94 commented Feb 20, 2024

I mean the idata filename should have a better name

@twiecki twiecki changed the title Delete accidental folder models Rename models folder Mar 8, 2024
@twiecki
Copy link
Contributor

twiecki commented Mar 8, 2024

So yes, two issues:

  • Rename the idata file to have a better name
  • Rename datasets to data, move the idata file to data.

@twiecki twiecki added the good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package label Mar 8, 2024
juanitorduz pushed a commit that referenced this issue Apr 11, 2024
twiecki pushed a commit that referenced this issue Sep 10, 2024
twiecki pushed a commit that referenced this issue Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants