-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename models
folder
#520
Comments
Isn't this used for one of the notebooks? |
Which notebook? Should be in datasets if needed but is it needed? |
the budget allocation |
Should go here then no? It's where we save other data for examples https://github.com/pymc-labs/pymc-marketing/tree/main/datasets And maybe have a better name? |
Yeah, if the notebooks are to be reproducible from a cloned repo. Might be better to use
I'm not good at naming 😆 How about |
I mean the idata filename should have a better name |
So yes, two issues:
|
https://github.com/pymc-labs/pymc-marketing/tree/main/models
The text was updated successfully, but these errors were encountered: