Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary NonImplemented errors from abstract methods #662

Merged
merged 5 commits into from
May 2, 2024
Merged

Remove unnecessary NonImplemented errors from abstract methods #662

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4572199
ignore non-implemented
juanitorduz May 1, 2024
54f9fe2
remove not implemented error from abstract classes
juanitorduz May 2, 2024
1afae7d
Merge branch 'main' into code_cov_config
juanitorduz May 2, 2024
12916f7
simplify docstrings
juanitorduz May 2, 2024
6abd3fb
Merge branch 'main' into code_cov_config
juanitorduz May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions pymc_marketing/model_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ def _data_setter(

"""

raise NotImplementedError

@property
@abstractmethod
def output_var(self):
Expand All @@ -143,7 +141,6 @@ def output_var(self):
output_var : str
Name of the output variable of the model.
"""
raise NotImplementedError

@property
@abstractmethod
Expand Down Expand Up @@ -172,7 +169,6 @@ def default_model_config(self) -> dict:
model_config : dict
A set of default parameters for predictor distributions that allow to save and recreate the model.
"""
raise NotImplementedError

@property
@abstractmethod
Expand All @@ -196,7 +192,6 @@ def default_sampler_config(self) -> dict:
sampler_config : dict
A set of default settings for used by model in fit process.
"""
raise NotImplementedError

@abstractmethod
def _generate_and_preprocess_model_data(
Expand Down Expand Up @@ -229,7 +224,6 @@ def _generate_and_preprocess_model_data(
None

"""
raise NotImplementedError

@abstractmethod
def build_model(
Expand Down Expand Up @@ -264,13 +258,7 @@ def build_model(
Returns
-------
None

Raises
------
NotImplementedError
This is an abstract method and must be implemented in a subclass.
"""
raise NotImplementedError

def set_idata_attrs(self, idata=None):
"""
Expand Down
Loading