Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference changed to dataset #873

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Inference changed to dataset #873

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8b0675
infernece changed to dataset
Ishaanjolly Jul 25, 2024
7f3054e
Merge branch 'main' into dev_ishaan
wd60622 Jul 25, 2024
b7dd3c7
inference changed dataset for plot_allocated_contribution_by_channel
Ishaanjolly Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pymc_marketing/mmm/delayed_saturated_mmm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2232,7 +2232,7 @@ def allocate_budget_to_maximize_response(

def plot_budget_allocation(
self,
samples: az.InferenceData,
samples: Dataset,
figsize: tuple[float, float] = (12, 6),
ax: plt.Axes | None = None,
original_scale: bool = True,
Expand All @@ -2242,8 +2242,8 @@ def plot_budget_allocation(

Parameters
----------
samples : az.InferenceData
The inference data containing the channel contributions.
samples : Dataset
The dataset containing the channel contributions.
figsize : tuple[float, float], optional
The size of the figure to be created, by default (12, 6).
ax : plt.Axes, optional
Expand Down Expand Up @@ -2331,7 +2331,7 @@ def plot_budget_allocation(

def plot_allocated_contribution_by_channel(
self,
samples: az.InferenceData,
samples: Dataset,
lower_quantile: float = 0.025,
upper_quantile: float = 0.975,
original_scale: bool = True,
Expand All @@ -2345,8 +2345,8 @@ def plot_allocated_contribution_by_channel(

Parameters
----------
samples : az.InferenceData
The inference data containing the samples of channel contributions.
samples : Dataset
The dataset containing the samples of channel contributions.
lower_quantile : float, optional
The lower quantile for the uncertainty interval. Default is 0.025.
upper_quantile : float, optional
Expand Down
Loading