Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HP11713A Switch & Attenuator Driver #970

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Add HP11713A Switch & Attenuator Driver #970

merged 5 commits into from
Oct 10, 2023

Conversation

neuschs
Copy link
Contributor

@neuschs neuschs commented Oct 2, 2023

No description provided.

BenediktBurger
BenediktBurger reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@BenediktBurger BenediktBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I added a few questions and suggestions.

docs/api/instruments/hp/hp11713A.rst Show resolved Hide resolved
pymeasure/instruments/hp/hp11713a.py Outdated Show resolved Hide resolved
pymeasure/instruments/hp/hp11713a.py Outdated Show resolved Hide resolved
pymeasure/instruments/hp/hp11713a.py Outdated Show resolved Hide resolved
pymeasure/instruments/hp/hp11713a.py Show resolved Hide resolved
@BenediktBurger
Copy link
Member

Maybe you could expand the documentation a little bit, such that it is easier for the users to understand the use of the attenuator dictionaries.

The code itself, however, is good.

@BenediktBurger
Copy link
Member

Thanks for your contribution.

@BenediktBurger BenediktBurger changed the title HP11713A Switch & Attenuator Driver Add HP11713A Switch & Attenuator Driver Oct 10, 2023
@BenediktBurger BenediktBurger merged commit e0ff4a3 into pymeasure:master Oct 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktBurger BenediktBurger BenediktBurger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neuschs @BenediktBurger