-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
performance could be improved #73
Comments
cc @joshowen |
Is the reason for using OrderedDicts purely cosmetic @jlafon? |
We've monkey patched in cyordereddict, and it has performed well (If we have to use OrderedDicts anywhere) |
The logging could be sped up a bit too by letting logger decide when to format log lines |
@danielhochman OrderedDicts are used to make testing easier between Python 2 and 3 (the tests can assert that two dictionaries are equal by iterating over the key, value pairs in a deterministic order). We could remove OrderedDicts and write the tests differently. |
Thank you all for contributing. I've fixed up the tests to work with all of the improvements that you have made. All of the changes have been merged into the devel branch. If you have time, please test it to make sure everything works as expected for you. |
We're using this session:
with the changes in #91 to speed up a lot of calls to DynamoDB in greenlets |
Potential performance improvements:
The text was updated successfully, but these errors were encountered: