-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ujson if its available #78
Conversation
This area of the code will pay the biggest dividend in terms of switching out the parser. Also not calling .json() twice in that block would be a good idea. |
That is where the monkey patching mentioned above comes in. And json isn't called twice there, the first branch raises. |
we don't need to patch though, why not call json.loads(request.text)? |
+1 from me |
@jlafon any thoughts |
# Conflicts: # pynamodb/connection/base.py
Thoughts on merging this in? I'm happy to update the branch. We've been using this in production for a while. |
@joshowen definitely. let's take advantage of the new global config introduced in 1.6.0 and allow you to globally patch in whatever json parser you want, defaulting to the built-in json. let me know if you have any questions. |
If you have it, might as well monkey patch botocore.vendored.requests to use it too, but thats out of scope.
https://github.com/kennethreitz/requests/issues/1595