4.x: workaround for _convert_to_request_dict change (#1083) #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikonst
force-pushed
the
2022-12-07-4.x-_convert_to_request_dict
branch
3 times, most recently
from
54a0be4 to
9f590c0
Compare
ikonst
changed the title
ikonst
force-pushed
the
2022-12-07-4.x-_convert_to_request_dict
branch
2 times, most recently
from
e916f55 to
a398bd8
Compare
botocore 1.28 changed the signature of private method botocore.client.BaseClient._convert_to_request_dict adding an endpoint_url parameter. We are updating pynamodb to inspect the signature and add this parameter as needed.
ikonst
force-pushed
the
2022-12-07-4.x-_convert_to_request_dict
branch
from
a398bd8 to
adac9cd
Compare
michael-k
added a commit
to michael-k/aws-xray-sdk-python
that referenced
this pull request
Jan 10, 2023
PynamoDB 4.4.0 introduced syntax that's only valid on Python >= 3.6 while still claiming to support Python < 3.6. See pynamodb/PynamoDB#1130
willarmiros
pushed a commit
to aws/aws-xray-sdk-python
that referenced
this pull request
Jan 12, 2023
PynamoDB 4.4.0 introduced syntax that's only valid on Python >= 3.6 while still claiming to support Python < 3.6. See pynamodb/PynamoDB#1130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
botocore 1.28 changed the signature of private method
botocore.client.BaseClient._convert_to_request_dictadding anendpoint_urlparameter. We are updating pynamodb to inspect the signature and add this parameter as needed.Backport to 4.x of #1083 and #1087.