Fixing remaining ID inconsistencies in AHF handler #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
approved these changes
May 12, 2022
Co-authored-by: Corentin Cadiou <contact@cphyc.me>
|
I never know how to test specific handlers, most of hem and their features are untested and lack infrastructures to do so (historically, I suspect the rationale was to test the base interface but not its case-by-case implementations) PS: Could any of you help me fix the pre-commit failing test? I don't really get what's going wrong |
|
pre-commit.ci autofix |
2 similar comments
|
pre-commit.ci autofix |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @apontzen and @cphyc,
We realised with @gandhalij that the mapping between parent haloes and child sub haloes is currently broken by the differences between AHF
IDandhalo_idexplained in #178.The current implementation assumes that
hostHaloencodes thehalo_idof the host, whereas it really encodes itsID. This PR fixes this inconsistency, adding a mechanism to mapIDandhalo_idfor the general case in which they are non-trivially related.Comments welcome!
Martin