RTT: search for RTT control block in smaller chunks #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flit
requested changes
Apr 27, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
this speeds up the searching dramatically since it will read and search 1024 bytes at the time instead of reading all memory on the device. Signed-off-by: Johan Carlsson <johan.carlsson@teenage.engineering>
te-johan
force-pushed
the
rtt_chunk_search
branch
from
5ba77b2
to
762b09a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for adding your copyright! |
flit
approved these changes
Apr 28, 2022
flit
pushed a commit
that referenced
this pull request
Apr 28, 2022
this speeds up the searching dramatically since it will read and search 1024 bytes at the time instead of reading all memory on the device. Signed-off-by: Johan Carlsson <johan.carlsson@teenage.engineering> Co-authored-by: Johan Carlsson <johan.carlsson@teenage.engineering>
|
@te-johan Fyi, so you're not surprised, I moved this commit over to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recently started using pyOCD and noticed that RTT searched for the control block rather slow.
when testing on my device to took 0.3 seconds to find it compared to 4.3 seconds before this commit.