Debug probe pins API #1478
Merged
Debug probe pins API #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DebugProbe: Add Pin class with pin mask constants, .read_pins() and .write_pins() methods, and .readable_pins and .writable_pins properties. - CMSISDAPProbe, JLinkProbe: implement new pin access APIs. - pyDAPAccess: Add .pin_access() API for sending DAP_SWJ_Pins command from CMSISDAPProbe.
Allows direct use of new debug probe pin access API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new API to the
DebugProbeabstract class to enable reading and writing of pins provided by the debug probe. Presence of this API is indicated by the probe having theDebugProbe.Capability.PIN_ACCESScapability.This pins API is quite simple and rather limited in some ways. For protocol-type pins, it's fine. But for GPIO you'd probably want more explicit control.
Support is included for the CMSIS-DAP and Segger JLink probe drivers.
New API methods:
DebugProbe.get_accessible_pins(group: PinGroup) -> NoneReturns the readable and writable for a given pin group.
DebugProbe.read_pins(group: PinGroup, mask: int) -> intRead a selection of pins from one group.
DebugProbe.write_pins(group: PinGroup, mask: int, value: int) -> NoneWrite a selection of pins from one group.
There are currently two pin groups defined:
DebugProbe.PinGroup.PROTOCOL_PINS— the usual SWD/JTAG/reset pinsDebugProbe.PinGroup.GPIO_PINS— reserved for future access of GPIO pins provided by a debug probe, not implemented by any debug probe driver yet (it's possible for JLink, but I don't have a JLink with GPIO so couldn't test)Other changes:
accessible-pinsandpinsvalues to use withsetandshowcommands.