Migrate away from deprecated pkg_resources #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flit
force-pushed
the
bugfix/deprecated_pkg_resources
branch
from
3ad5639
to
6da0009
Compare
- pkg_resources is deprecated; switch to importlib replacements. - importlib_metadata is used instead of stdlib importlib.metadata because we want the selectable entry_points() API that is only available with importlib.metadata from Python 3.10 or importlib_metadata 3.6+. - Similarly, importlib_resources is used instal of importlib.resources to get access to the latest API on all supported Python versions. - Add a basic unit test to ensure loading of builtin SVD files works.
flit
force-pushed
the
bugfix/deprecated_pkg_resources
branch
from
6da0009
to
8976b76
Compare
flit
pushed a commit
that referenced
this pull request
Aug 5, 2023
Search only for the length of control block ID. Fixes #1533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces use of
pkg_resourceswith the replacements,importlib.resourcesandimportlib_metadata. Note thatimportlib_metadatais used instead of the standard libimportlib.metadatabecause the selectable.entry_points()API is desired, and that is only available fromimportlib_metadataversion 3.6 included since Python 3.10.A small unit test for loading builtin SVD data is added.