core: session: load the user script after the board is constructed #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear why, originally, the user script was loaded before the board is created. In any case, the namespace update on .open() is retained. Even though all the objects added to the namespace are available now when the user script is loaded, they aren't really usable since nothing is opened/connected/inited.
|
After this commit, is there still a way to regist a new target without modify files of pyocd, like #981 does? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the user script to load after the
Boardinstance is created.The benefit is that top level objects exist when the script is loaded. Although, they aren't opened/connected/inited, so aren't really useful for much.
The downside is that you can't set
target_overrideinside the script top-level. It can only be set from the yaml config file or command line.Not sure when this PR will be merged.