core: session: only create one session to access options when there's no current session #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no current session If Session.current_session is accessed without a valid current session, an empty Session is created and retained via a strong reference. This mostly happens when session options are read prior to the main session being created. Since the ._current_session attribute is a weakref, the options session instance would previously be collected immediately after use, leading to repeated creation of options sessions in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Session.current_sessionis accessed without a valid current session, an emptySessionis created and retained via a strong reference. This mostly happens when session options are read prior to the main session being created.Since the
._current_sessionattribute is a weakref, the options session instance would previously be collected immediately after use, leading to repeated creation of options sessions in some cases.