probe: cmsis-dap: use Transfer command for one-byte transfer #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkitayam
force-pushed
the
cmsis-dap-use-transfer-for-1-byte
branch
from
b13f482
to
8ffd5e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation, one-byte transfer is encoded with TransferBlock command. But, in case of one-byte transfer, it is better to use Transfer command to reduce USB packet size.
TransferBlock command with one-byte read consumes 5 bytes size.
Transfer command with one-byte read consumes 4 bytes size.
TransferBlock command with one-byte write consumes 9 bytes size.
Transfer command with one-byte write consumes 8 bytes size.