Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect default port #1650

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: incorrect default port #1650

merged 1 commit into from
Jun 27, 2024

Conversation

FredeEB
Copy link
Contributor

@FredeEB FredeEB commented Dec 4, 2023

No description provided.

@jcw
Copy link

jcw commented May 10, 2024

A typo fix takes more than more than 5 months to be accepted? Worrying ...

@FredeEB
Copy link
Contributor Author

FredeEB commented May 10, 2024

@jcw a comment that bashes on open source maintainers not prioritizing documentation for software that they produce for free?

Even worse

Open Source takes time. Please respect that

@jcw
Copy link

jcw commented May 10, 2024

My apologies if this came across as bashing.
This was a comment on the process, not the people.
I can delete it, if you prefer.

@ithinuel
Copy link
Member

ithinuel commented Jun 27, 2024

Ok, CI did not because it ignores changes in docs.

Actually it should have at least ran the "skipped" pipeline instead. I don't know why it's not running yet.

@ithinuel ithinuel merged commit 456cbf8 into pyocd:main Jun 27, 2024
@ithinuel
Copy link
Member

Thank you for your patience.

@FredeEB FredeEB deleted the patch-1 branch July 10, 2024 19:33
joshua-nmi pushed a commit to NorthernMechatronics/pyOCD that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants