Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the offset in finding control block #1654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reset the offset in finding control block #1654

wants to merge 1 commit into from

Commits on Dec 18, 2023

  1. Reset the offset in finding control block 

    This commit fixes an issue where the control block id was not found
in cases where the bytes spanned two read blocks.

Example data block causing the original issue:

`01:08:18.444,458] <dbg> SEGGER R`

In this case the code skips 24 bytes, making the next loop start with:

`SEGGER RTT\x00\x00\x00\x00…`

Unfortunately `offset` is still `8`, which the first byte does not
match. The offset is then reset, but by that time the first byte has
already been skipped over.
    @KenMacD
    KenMacD committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    94debab View commit details
    Browse the repository at this point in the history