Allow injecting kwargs to fetch during installing #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
reviewed
Jul 25, 2024
| @@ -20,6 +20,7 @@ async def install( | |||
| index_urls: list[str] | str | None = None, | |||
| *, | |||
| verbose: bool | int = False, | |||
| **fetch_kwargs, | |||
There was a problem hiding this comment.
Let's not use kwargs, and pass a dictionary instead.
fetch_args: dict[str, Any] | None = {...}
There was a problem hiding this comment.
Also, as credentials is part of fetch args, I think we can deprecate it in favor to fetch args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #122
But will the next version released after implementing #112? If this feature is going to be added there then there is no need to merge this tiny commit.