Bump Pyodide on CI #130
Bump Pyodide on CI #130
Conversation
Also change to explicitely use strings. I'm guessing this should be bumped, maybe there is an automatic way to do latest ? Also not sure if you want to test on alphas, but I guess it's always useful to catch bugs.
tests/test_uninstall.py
Outdated
| if parse(pyodide.__version__) < parse("0.27"): | ||
| assert len(logs) == 2, logs | ||
| assert "does not exist" in logs[-1] | ||
| assert "does not exist" in logs[-2] | ||
| else: | ||
| assert logs == [""] |
There was a problem hiding this comment.
@ryanking13 Looks like a regression?
There was a problem hiding this comment.
Hmm, indeed, the warning is not shown at 0.26.0...
|
Thanks @Carreau! Why not split this into a PR which adds 0.26 which we certainly want, and a second PR that adds 0.27.0a2 so we can investigate the failure there and make an appropriate fix without blocking the addition of 0.26? |
|
0.26 also has the regression, and there does not seem to be any other regression between 0.26 and 0.27.0a2, so hopefully it's not more difficult. I also see selenium Timeouts and that I'm a bit flumoxed. |
|
Also any pointers on change the value of the selenium timeouts ? I think it's 600 for now, (i'm guessing seconds ?). That would help making failing test faster |
| @@ -61,6 +61,9 @@ def uninstall(packages: str | list[str], *, verbose: bool | int = False) -> None | |||
| # - scripts | |||
| # - entry_points | |||
| # Since we don't support these, we can ignore them (except for data_files (TODO)) | |||
| logger.warning( | |||
| "skipping file '%s' that is relative to root", | |||
There was a problem hiding this comment.
| "skipping file '%s' that is relative to root", | |
| "skipping file '%s' that is relative to root", str(file), |
tests/test_uninstall.py
Outdated
| if parse(pyodide.__version__) < parse("0.27"): | ||
| assert len(logs) == 2, logs | ||
| assert "does not exist" in logs[-1] | ||
| assert "does not exist" in logs[-2] | ||
| else: | ||
| assert logs == [""] |
There was a problem hiding this comment.
Hmm, indeed, the warning is not shown at 0.26.0...
|
It seems like importlib changed in Python 3.12 to not list non-existing files in the distribution, that's why we are not logging the removed files when uninstalling. Probably then, you could just remove that test ( |
As pointed out by Gyeongjae Choi in 130, those file are listed since Python 3.12 and thus this error shouls not trigger.
|
Ok, let's try. I left the warning message (I guess there are other case were files might not be a file...), but added a comment it was likely unnecessary,. |
|
Thanks ! |
Also change to explicitely use strings.
I'm guessing this should be bumped, maybe there is an automatic way to do latest ? Also not sure if you want to test on alphas, but I guess it's always useful to catch bugs.