Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verbose option to install and uninstall #60

Merged
merged 13 commits into from
Apr 26, 2023
Merged

Add verbose option to install and uninstall #60

merged 13 commits into from
Apr 26, 2023

Conversation

ryanking13
Copy link
Member

@ryanking13 ryanking13 commented Apr 14, 2023 •
edited
Loading

This adds verbose parameter to micropip.install and micropip.uninstall.

Setting verbose=True will print the installation/uninstallation process.

image

A known issue is that it does not show dependencies of packages in repodata.json (as it is handled by loadPackage)

image

  • changelog

rth
rth approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks a lot @ryanking13 ! Overall LGTM.

micropip/_utils.py Outdated Show resolved Hide resolved
micropip/transaction.py Show resolved Hide resolved
@ryanking13 ryanking13 mentioned this pull request Apr 26, 2023
Open
2 tasks
@ryanking13 ryanking13 merged commit 274d0b3 into pyodide:main Apr 26, 2023
@ryanking13 ryanking13 deleted the verbose-logging branch April 26, 2023 01:45
@ryanking13 ryanking13 mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanking13 @rth