Options to fix dependencies of manually loaded packages #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
Sep 1, 2023
hoodmane
reviewed
Sep 1, 2023
hoodmane
reviewed
Sep 1, 2023
hoodmane
reviewed
Sep 1, 2023
hoodmane
reviewed
Sep 1, 2023
hoodmane
reviewed
Sep 1, 2023
…nto fix_dependencies
|
I refactored it so fix_package_dependencies lives in _utils and got rid of the public facing function which wasn't really useful except in conjuction with freeze anyway. |
for more information, see https://pre-commit.ci
…ropip into fix_dependencies
|
Oh and fixed / added tests for freeze. |
ryanking13
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Thanks @joemarshall!
I have some minor comments otherwise LGTM.
Could you please update the changelog? I think we can use a version 0.4.1 and release with this PR.
|
Okay, I think I've done those changes okay now |
for more information, see https://pre-commit.ci
…ropip into fix_dependencies
for more information, see https://pre-commit.ci
|
Thanks @joemarshall! Pyodide 0.24.0 has already been released, so I think this would be included in 0.24.1 |
|
Oh wait this is a micropip change, not sure if these labels make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you import packages from wheel files without automatically getting dependencies,
micropip.freezewon't correctly show dependencies for the packages.This patch fixes up dependencies for manually loaded wheels, adding a method
micropip.check_package_dependenciesto check and fix dependencies for a package.It also uses the same function to make
micropip.freezework even if you just manually load a wheel and all dependencies.Still not sure whether this would be better in pyodide-lock, but I think given
micropip.freezeexists, this patch that makes it work in this case seems reasonably sensible.