ENH Add Headers to node scope #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the difference between this PR and #119? It has the same title. |
|
Oops I was not paying attention when I made this. This is here for just the last commit, I'll rebase just that commit onto main and rename the PR. |
ryanking13
reviewed
Nov 15, 2023
hoodmane
force-pushed
the
add-headers
branch
from
fea6c83
to
bedf8de
Compare
hoodmane
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix CI on pyodide/pyodide#4282.
Maybe we should consider putting the entire node global scope in?