Add a global manager for configuring runtimes #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…/pytest-pyodide into global-state-manager2
1 task
hoodmane
approved these changes
Jul 22, 2024
pytest_pyodide/config.py
Outdated
| def set_flag(self, runtime: RUNTIMES, flags: list[str]): | ||
| self.flags[runtime] = flags | ||
|
|
||
| def get_flag(self, runtime: RUNTIMES) -> list[str]: |
There was a problem hiding this comment.
Wouldn't this be get_flags / set_flags plural?
That is true, but at least we now provide a public API that is less likely to change. In the follow-up, I would like to put the values like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a global config manager for pytest-pyodide.
This is mostly for use in pyodide, where we already modify browser flags in conftest.py. This PR aims to provide a more stable and public API to modify them.