Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for plugin commandline options #75

Merged
merged 6 commits into from
Dec 14, 2022

Conversation

ryanking13
Copy link
Member

This adds tests for plugin cmdline options --dist-dir, --runner, --runtime, while removing a test-config that makes #59 fail.

@ryanking13 ryanking13 changed the title Add tests for plugin options Add tests for plugin commandline options Dec 13, 2022
@hoodmane
Copy link
Member

I find that these don't work as expected:

pytest --rt chrome some/file.py # won't work 
pytest --rt=chrome some/file.py # works
pytest some/file.py --rt chrome # works 

@ryanking13
Copy link
Member Author

I find that these don't work as expected:

Yeah.. accepting a list-type parameter in argparse is quite a bit annoying. Maybe we should change it to get a comma-separated list of runtimes instead? e.g. --rt "chrome,firefox,node"

@ryanking13 ryanking13 merged commit 2a7c5c6 into pyodide:main Dec 14, 2022
@ryanking13 ryanking13 deleted the test-options branch December 14, 2022 00:17
@ryanking13 ryanking13 restored the test-options branch December 14, 2022 00:17
@ryanking13 ryanking13 deleted the test-options branch December 14, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants