Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the parameter when preparing request body #116

Merged
merged 1 commit into from Mar 29, 2017
Merged

Resolve the parameter when preparing request body #116

merged 1 commit into from Mar 29, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 29, 2017

Request has empty HTTP body If a body parameter is defined with a $ref. This patch takes the resolved parameter values to fix this issue. I am not sure on how to write a test for this by providing schema in code.

Request has empty HTTP body If a body parameter is defined with a $ref. This patch takes the resolved parameter values to fix this issue.
@coveralls
Copy link

coveralls commented Mar 29, 2017

Coverage Status

Coverage increased (+0.002%) to 94.234% when pulling d8ba16d on surajbarkale-dolby:patch-1 into 163f6e8 on mission-liao:master.

@mission-liao
Copy link
Member

mission-liao commented Mar 29, 2017

that's an obvious bug, I'll add test case for it later this week.

=========
I'm late on this item, but corresponding test case (and another identical issue) is added, refer to #119

@mission-liao mission-liao merged commit f706ba6 into pyopenapi:master Mar 29, 2017
@ghost ghost deleted the patch-1 branch March 29, 2017 22:56
@mission-liao mission-liao added this to the v0.8.28 milestone Apr 1, 2017
mission-liao added a commit that referenced this pull request Apr 15, 2017
[fix]
missing body parameter when referenced from “parameters” field
- #116
- #119

special characters in path parameters not handled correctly
- #117

query parameter doesn't pass to Webapp2's client
- #114
mission-liao added a commit to pyopenapi/pyopenapi that referenced this pull request Aug 12, 2017
[fix]
missing body parameter when referenced from “parameters” field
- pyopenapi/pyswagger#116
- pyopenapi/pyswagger#119

special characters in path parameters not handled correctly
- pyopenapi/pyswagger#117

query parameter doesn't pass to Webapp2's client
- pyopenapi/pyswagger#114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants