Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manylinux_2_27 policy #299

Closed
auscompgeek opened this issue Mar 23, 2021 · 2 comments · Fixed by #300
Closed

Add manylinux_2_27 policy #299

auscompgeek opened this issue Mar 23, 2021 · 2 comments · Fixed by #300
Labels
enhancement

Comments

@auscompgeek
Copy link

Hey team!

We at @robotpy build wheels on Ubuntu 18.04 (as our upstream targets 18.04). We've been manually tagging our wheels as manylinux_2_27 as we wanted to get our wheels on PyPI quickly early this year. It'd be awesome if we could use auditwheel instead to check that our wheels are actually compliant.
mayeut added a commit to mayeut/auditwheel that referenced this issue Mar 27, 2021
@mayeut
Add manylinux_2_27 policy
e474199 
This policy is based on symbols from ubuntu 18.04 with GLIBCXX_3.4.25 symbols removed (introduced in gcc-8 and incompatible with Photon 3 distro based on glibc 2.28).

As long as gcc-7 is used on ubuntu 18.04, using this distro should lead to manylinux_2_27 compliant wheels.

Symbol compatibility analysis done using https://github.com/mayeut/pep600_compliance data.

Fix pypa#299
@mayeut mayeut mentioned this issue Mar 27, 2021
Merged
@mayeut
Copy link
Member

mayeut commented Mar 27, 2021

Hello @auscompgeek,

I created #300 to add the manylinux_2_27 policy. I'm not sure how we can test this policy in CI for now. Could you please have a look to check wether or not you're seeing issues on wheels from @robotpy (unless others are doing the same thing as you are, that would be roughly 15 packages ?)

@auscompgeek
Copy link
Author

auscompgeek commented Mar 27, 2021 •
edited
Loading

Awesome, thanks! Looks like with #300 auditwheel is satisfied our existing wheels (grabbed from downloading robotpy[all]) are consistent with manylinux_2_27, with the exception of our robotpy-halsim-* packages which apparently have an existing unrelated problem we've overlooked.

mayeut added a commit that referenced this issue Mar 28, 2021
@mayeut
Add manylinux_2_27 policy (#300)
7d4090b 
This policy is based on symbols from ubuntu 18.04 with GLIBCXX_3.4.25 symbols removed (introduced in gcc-8 and incompatible with Photon 3 distro based on glibc 2.28).

As long as gcc-7 is used on ubuntu 18.04, using this distro should lead to manylinux_2_27 compliant wheels.

Symbol compatibility analysis done using https://github.com/mayeut/pep600_compliance data.

Fix #299
@mayeut mayeut mentioned this issue Apr 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add manylinux_2_27 policy mayeut/auditwheel
2 participants
@auscompgeek @mayeut