Ensure Travis fails when tests fail [ignore CI failure] #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I want the tests to fail, not error. Guess I'll try something else... |
Closed
|
So the current test failure is legitimate thanks to #107. I'm going to try to fix that too, but feel free to merge this PR and I can submit that separately. |
ehashman
changed the title
|
I think we should replace the script block by an actual script file, that uses |
|
|
|
+1 |
|
This should be good to go! |
|
bump |
Conflicts: .travis.yml
|
I got a +1 so once CI completes for this merge of the new changes I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #105.