Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused imports in different files #117

Merged
merged 1 commit into from
Nov 18, 2018

Conversation

atombrella
Copy link
Contributor

It overlaps with #116 but this just removes unused imports.

@ehashman
Copy link
Member

ehashman commented Nov 5, 2018

Hi @atombrella! These PRs all look totally reasonable, I just want to get some earlier stuff merged before I hit merge on these so I don't create conflicts.

Thanks for your contributions!

@ehashman
Copy link
Member

Mind fixing the merge conflicts?

@atombrella
Copy link
Contributor Author

@ehashman Done.

@ehashman
Copy link
Member

Great. I'm going to hold off on this PR until I get manylinux2010 merged as this is highly likely to make that PR unmergeable and I'd rather take these changes second. Thanks!

Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and it passes. Travis is being irritatingly flaky today.

@ehashman ehashman merged commit 3679a89 into pypa:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants