Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some unused variables #121

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Removed some unused variables #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions auditwheel/lddtree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,9 @@ def load_ld_paths(root: str='/', prefix: str='') -> Dict[str, List[str]]:
-------
dict containing library paths to search
"""
ldpaths = {'conf': [], 'env': [], 'interp': [], }
ldpaths = {'conf': [], 'env': [], 'interp': []}

# Load up $LD_LIBRARY_PATH.
ldpaths['env'] = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, this was already set in L187.

env_ldpath = os.environ.get('LD_LIBRARY_PATH')
if env_ldpath is not None:
if root != '/':
Expand Down
3 changes: 1 addition & 2 deletions auditwheel/wheel_abi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def analyze_wheel_abi(wheel_fn: str):
elftree_by_fn, external_refs_by_fn, versioned_symbols, has_ucs2, uses_PyFPE_jbuf= \
get_wheel_elfdata(wheel_fn)

for fn, elftree in elftree_by_fn.items():
for fn in elftree_by_fn.keys():
update(external_refs, external_refs_by_fn[fn])

log.info(json.dumps(external_refs, indent=4))
Expand All @@ -117,7 +117,6 @@ def analyze_wheel_abi(wheel_fn: str):
else:
ucs_policy = POLICY_PRIORITY_HIGHEST


if uses_PyFPE_jbuf:
pyfpe_policy = POLICY_PRIORITY_LOWEST
else:
Expand Down
2 changes: 1 addition & 1 deletion auditwheel/wheeltools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def add_platforms(wheel_ctx, platforms, remove_platforms=()):
else:
print('No filename tags change needed.')

wheel_base, ext = splitext(wheel_fname)
_, ext = splitext(wheel_fname)
fparts['plat'] = '.'.join(fname_tags)
fparts['ext'] = ext
out_wheel_fname = "{namever}-{pyver}-{abi}-{plat}{ext}".format(**fparts)
Expand Down