-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve log message in case of NonPlatformWheel error #393
Conversation
Codecov ReportBase: 92.42% // Head: 92.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 23 23
Lines 1267 1268 +1
Branches 311 311
=======================================
+ Hits 1171 1172 +1
Misses 55 55
Partials 41 41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It seems that the fails in the pipeline are not connected to the changes in this PR, but are due to travis ci worker handing |
I've updated. I've taken the liberty of creating a constant with the message, since it was used in 3 different places, but I'm not sure if where I placed it is the correct place. I can remove it if you prefer not having it |
thanks @CaselIT ! |
The current log message in case a wheel file contains no compiled extension is not very clear regarding that's the issue is.
I've tried to add a clarification that I how will make it clearer for uses to understand what when wrong
(I opened pypa/cibuildwheel#1247 since it was not clear to me that the error meant, I though it was complaining about the file name abi identifier or something similar)