Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OrderedDict #441

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Remove OrderedDict #441

merged 3 commits into from
Sep 11, 2023

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Aug 21, 2023

Since Python 3.7 the insertion order to dict has been preserved, thus OrderedDict is no longer necessary.

Note that src/auditwheel/_vendor/wheel/wheelfile.py uses OrderedDict, but is not modified. This was modified upstream from pypa/wheel#561

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (fe76c14) 92.33% compared to head (3f9bfdb) 92.31%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   92.33%   92.31%   -0.02%     
==========================================
  Files          23       23              
  Lines        1291     1289       -2     
  Branches      302      302              
==========================================
- Hits         1192     1190       -2     
  Misses         57       57              
  Partials       42       42              
Files Changed Coverage Δ
src/auditwheel/main_show.py 82.75% <100.00%> (-0.30%) ⬇️
src/auditwheel/repair.py 86.61% <100.00%> (-0.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the test failures

Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
@auvipy auvipy merged commit 325ac7b into pypa:main Sep 11, 2023
10 checks passed
@auvipy
Copy link
Contributor

auvipy commented Sep 11, 2023

merged as the tests were passing

@mwtoews mwtoews deleted the rm-ordereddict branch September 11, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants