Nonrecursive get_req_external. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recursive implementation of get_req_external would fail when two libraries are linked against each each other, e.g. libfreetype.so.6 and libharfbuzz.so.0 on Arch Linux.
|
LGTM |
ehashman
approved these changes
Nov 8, 2017
|
Any chance for a release some time soon? Thanks. |
|
I'll cut one later today @anntzer! |
|
Release done and uploaded to PyPI. Let me know if there are any issues. https://github.com/pypa/auditwheel/releases/tag/1.8 |
|
You might want to rev the docker image too
On Dec 28, 2017 14:18, "Elana Hashman" <notifications@github.com> wrote:
Release done and uploaded to PyPI. Let me know if there are any issues.
https://github.com/pypa/auditwheel/releases/tag/1.8
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#84 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAlOaAHcaMozGsm_fTN5lR2WR61TiS8Mks5tFBPRgaJpZM4PdObK>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recursive implementation of get_req_external would fail when two
libraries are linked against each each other, e.g. libfreetype.so.6 and
libharfbuzz.so.0 on Arch Linux.