Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the use of pep517 with pyproject-hooks because of the rename #539

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

KOLANICH
Copy link
Contributor

No description provided.

@KOLANICH
Copy link
Contributor Author

pypa/pyproject-hooks#151

@henryiii
Copy link
Contributor

henryiii commented Nov 22, 2022

Xref #529.

@KOLANICH KOLANICH force-pushed the pyproject_hooks branch 4 times, most recently from edcd0fd to 3ffa5bd Compare November 22, 2022 16:42
pyproject.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@KOLANICH KOLANICH force-pushed the pyproject_hooks branch 2 times, most recently from cc4e359 to 0cfabfa Compare November 22, 2022 16:56
@KOLANICH
Copy link
Contributor Author

This should be equal to the minimum version specified in pyproject.toml. Did you experience an issue with 1.0.0?

I personally don't (I don't install packages from pypi and in my pip installation the resolver is disabled), 1.0.0 works fine for me (though on my machine 2.0.1 is installed, spinned up a venv to test), but
https://github.com/pypa/pyproject-hooks/blob/main/pyproject.toml#L13 requires 1.1.0 and this makes pips resolver angry.

@layday
Copy link
Member

layday commented Nov 22, 2022

Ok, bump it in pyproject.toml too then please.

Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. We might not want to release for a while after this is merged, as it will take time to make this rename available in other ecosystems. Conda-forge, for example, does not have the renamed package yet.

@pradyunsg
Copy link
Member

We might not want to release for a while after this is merged, as it will take time to make this rename available in other ecosystems. Conda-forge, for example, does not have the renamed package yet.

Don't those redistributors also delay their ingestion of build, if they've got a delayed ingestion of other packages from PyPI?

@webknjaz
Copy link
Member

webknjaz commented Dec 2, 2022

Conda-forge, for example, does not have the renamed package yet.

Will it not work for them to just use an older version, then? Pretty sure this is how all downstream packagers would operate — they'll just package things in the order needed for the depresolver. It's kinda pointless to cater for a case that wouldn't even happen.

@rossburton
Copy link

Speaking with my distro maintainer hat on, don't wait. I'm waiting for a new release of build that uses flit and pyproject-hooks. :)

@henryiii
Copy link
Contributor

henryiii commented Dec 8, 2022

@layday, would you be okay to rebase #537 once? (I can do it for you next week). It might be nice to get a release out soon with flit and this. I’m on vacation the rest of the week, so I’m not volunteering quite yet. Also can’t review that PR till next week either. :(

@layday
Copy link
Member

layday commented Dec 8, 2022 via email

@henryiii henryiii closed this Dec 8, 2022
@henryiii henryiii reopened this Dec 8, 2022
@henryiii henryiii closed this Dec 13, 2022
@henryiii henryiii reopened this Dec 13, 2022
@henryiii
Copy link
Contributor

Looks okay to me. I say we merge unless anyone has objections.

@nanonyme
Copy link

Is this pending further review and approval or is it just waiting for someone to click the merge button?

@henryiii henryiii merged commit c99f58c into pypa:main Dec 26, 2022
@henryiii
Copy link
Contributor

The latter.

inmantaci referenced this pull request in inmanta/inmanta-core Jan 12, 2023
Bumps [build](https://github.com/pypa/build) from 0.9.0 to 0.10.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/pypa/build/blob/main/CHANGELOG.rst">build's changelog</a>.</em></p>
<blockquote>
<h1>0.10.0 (2023-01-11)</h1>
<ul>
<li>Replace <code>pep517</code> dependency with <code>pyproject_hooks</code>,
into which <code>pep517</code> has been renamed
(<code>PR [#539](https://github.com/pypa/build/issues/539)</code><em>, Fixes <code>[#529](https://github.com/pypa/build/issues/529)</code></em>)</li>
<li>Change build backend from <code>setuptools</code> to <code>flit</code>
(<code>PR [#470](https://github.com/pypa/build/issues/470)</code><em>, Fixes <code>[#394](https://github.com/pypa/build/issues/394)</code></em>)</li>
<li>Dropped support for Python 3.6 (<code>PR [#532](https://github.com/pypa/build/issues/532)</code>_)</li>
</ul>
<p>.. _PR <a href="https://github-redirect.dependabot.com/pypa/build/issues/470">#470</a>: <a href="https://github-redirect.dependabot.com/pypa/build/pull/470">pypa/build#470</a>
.. _PR <a href="https://github-redirect.dependabot.com/pypa/build/issues/532">#532</a>: <a href="https://github-redirect.dependabot.com/pypa/build/pull/532">pypa/build#532</a>
.. _<a href="https://github-redirect.dependabot.com/pypa/build/issues/394">#394</a>: <a href="https://github-redirect.dependabot.com/pypa/build/issues/394">pypa/build#394</a>
.. _PR <a href="https://github-redirect.dependabot.com/pypa/build/issues/539">#539</a>: <a href="https://github-redirect.dependabot.com/pypa/build/pull/539">pypa/build#539</a>
.. _<a href="https://github-redirect.dependabot.com/pypa/build/issues/529">#529</a>: <a href="https://github-redirect.dependabot.com/pypa/build/issues/529">pypa/build#529</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/pypa/build/commit/cd06da25481b9a610f846fa60cb67b5a5fa9a051"><code>cd06da2</code></a> release 0.10.0</li>
<li><a href="https://github.com/pypa/build/commit/9646f6890371c3efe61c09d138ed401a48cc618d"><code>9646f68</code></a> pre-commit: bump repositories (<a href="https://github-redirect.dependabot.com/pypa/build/issues/555">#555</a>)</li>
<li><a href="https://github.com/pypa/build/commit/c99f58ccb59b83736a4be5cdbd3a6da16c4d6c8f"><code>c99f58c</code></a> build: pep517 -&gt; pyproject-hooks (upstream project renamed) (<a href="https://github-redirect.dependabot.com/pypa/build/issues/539">#539</a>)</li>
<li><a href="https://github.com/pypa/build/commit/76d90b997f6e1db07d9c57b30f8b45e051afb922"><code>76d90b9</code></a> tests: fix for PEP 685 in packaging 22 (<a href="https://github-redirect.dependabot.com/pypa/build/issues/550">#550</a>)</li>
<li><a href="https://github.com/pypa/build/commit/656c48720f4c6d92a0d05aed41f17d8133d079c3"><code>656c487</code></a> pre-commit: bump repositories</li>
<li><a href="https://github.com/pypa/build/commit/e1612730c8ab56fab1e6b0355fb603b92cf762dd"><code>e161273</code></a> pre-commit: bump repositories</li>
<li><a href="https://github.com/pypa/build/commit/b8a1384d87575c1ea1781f3154366eb642161dd4"><code>b8a1384</code></a> ci: introduce a centralized GHA check/gate job (<a href="https://github-redirect.dependabot.com/pypa/build/issues/543">#543</a>)</li>
<li><a href="https://github.com/pypa/build/commit/a7617f8e8f4b91c7ecd535937027d706d41686f9"><code>a7617f8</code></a> types: fix mypy check</li>
<li><a href="https://github.com/pypa/build/commit/4475cf1bf2362cfba8dd8b10ac97b42d066db502"><code>4475cf1</code></a> pre-commit: bump repositories</li>
<li><a href="https://github.com/pypa/build/commit/3e7dc60e779cf95e793b02363e643556f61ed74a"><code>3e7dc60</code></a> pre-commit: add validate-pyproject</li>
<li>Additional commits viewable in <a href="https://github.com/pypa/build/compare/0.9.0...0.10.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=build&package-manager=pip&previous-version=0.9.0&new-version=0.10.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
github-actions bot referenced this pull request in MaRDI4NFDI/open-interfaces Jan 16, 2023
Bumps [build](https://github.com/pypa/build) from 0.9.0 to 0.10.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pypa/build/blob/main/CHANGELOG.rst">build's
changelog</a>.</em></p>
<blockquote>
<h1>0.10.0 (2023-01-11)</h1>
<ul>
<li>Replace <code>pep517</code> dependency with
<code>pyproject_hooks</code>,
into which <code>pep517</code> has been renamed
(<code>PR [#539](https://github.com/pypa/build/issues/539)</code><em>,
Fixes
<code>[#529](https://github.com/pypa/build/issues/529)</code></em>)</li>
<li>Change build backend from <code>setuptools</code> to
<code>flit</code>
(<code>PR [#470](https://github.com/pypa/build/issues/470)</code><em>,
Fixes
<code>[#394](https://github.com/pypa/build/issues/394)</code></em>)</li>
<li>Dropped support for Python 3.6 (<code>PR
[#532](https://github.com/pypa/build/issues/532)</code>_)</li>
</ul>
<p>.. _PR <a
href="https://github-redirect.dependabot.com/pypa/build/issues/470">#470</a>:
<a
href="https://github-redirect.dependabot.com/pypa/build/pull/470">pypa/build#470</a>
.. _PR <a
href="https://github-redirect.dependabot.com/pypa/build/issues/532">#532</a>:
<a
href="https://github-redirect.dependabot.com/pypa/build/pull/532">pypa/build#532</a>
.. _<a
href="https://github-redirect.dependabot.com/pypa/build/issues/394">#394</a>:
<a
href="https://github-redirect.dependabot.com/pypa/build/issues/394">pypa/build#394</a>
.. _PR <a
href="https://github-redirect.dependabot.com/pypa/build/issues/539">#539</a>:
<a
href="https://github-redirect.dependabot.com/pypa/build/pull/539">pypa/build#539</a>
.. _<a
href="https://github-redirect.dependabot.com/pypa/build/issues/529">#529</a>:
<a
href="https://github-redirect.dependabot.com/pypa/build/issues/529">pypa/build#529</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pypa/build/commit/cd06da25481b9a610f846fa60cb67b5a5fa9a051"><code>cd06da2</code></a>
release 0.10.0</li>
<li><a
href="https://github.com/pypa/build/commit/9646f6890371c3efe61c09d138ed401a48cc618d"><code>9646f68</code></a>
pre-commit: bump repositories (<a
href="https://github-redirect.dependabot.com/pypa/build/issues/555">#555</a>)</li>
<li><a
href="https://github.com/pypa/build/commit/c99f58ccb59b83736a4be5cdbd3a6da16c4d6c8f"><code>c99f58c</code></a>
build: pep517 -&gt; pyproject-hooks (upstream project renamed) (<a
href="https://github-redirect.dependabot.com/pypa/build/issues/539">#539</a>)</li>
<li><a
href="https://github.com/pypa/build/commit/76d90b997f6e1db07d9c57b30f8b45e051afb922"><code>76d90b9</code></a>
tests: fix for PEP 685 in packaging 22 (<a
href="https://github-redirect.dependabot.com/pypa/build/issues/550">#550</a>)</li>
<li><a
href="https://github.com/pypa/build/commit/656c48720f4c6d92a0d05aed41f17d8133d079c3"><code>656c487</code></a>
pre-commit: bump repositories</li>
<li><a
href="https://github.com/pypa/build/commit/e1612730c8ab56fab1e6b0355fb603b92cf762dd"><code>e161273</code></a>
pre-commit: bump repositories</li>
<li><a
href="https://github.com/pypa/build/commit/b8a1384d87575c1ea1781f3154366eb642161dd4"><code>b8a1384</code></a>
ci: introduce a centralized GHA check/gate job (<a
href="https://github-redirect.dependabot.com/pypa/build/issues/543">#543</a>)</li>
<li><a
href="https://github.com/pypa/build/commit/a7617f8e8f4b91c7ecd535937027d706d41686f9"><code>a7617f8</code></a>
types: fix mypy check</li>
<li><a
href="https://github.com/pypa/build/commit/4475cf1bf2362cfba8dd8b10ac97b42d066db502"><code>4475cf1</code></a>
pre-commit: bump repositories</li>
<li><a
href="https://github.com/pypa/build/commit/3e7dc60e779cf95e793b02363e643556f61ed74a"><code>3e7dc60</code></a>
pre-commit: add validate-pyproject</li>
<li>Additional commits viewable in <a
href="https://github.com/pypa/build/compare/0.9.0...0.10.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=build&package-manager=pip&previous-version=0.9.0&new-version=0.10.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants