-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify encoding. #578
Specify encoding. #578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though we had a static check for this - thanks!
Hmm, not seeing one in Ruff. Not sure to find one, then. I guess we can set the PYTHONWARNDEFAULTENCODING variable in the tests.
I recommend setting that var. that’s what I’ve done in other projects and how i found this one. I’ll update the PR. |
I would prefer if the env var was injected with |
Please do. Since there's no prior art in this repo for it, I'd prefer if a maintainer took it on so it ends up in the preferred place with the preferred style. I see some tests failing, and the failures don't appear to me to be related to the change. Please let me know if you need anything from me to handle that situation. |
Fixes failures when PYTHONWARNDEFAULTENCODING=1. Fixes #577.