Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat with typed pyproject-hooks #601

Closed
wants to merge 4 commits into from
Closed

Compat with typed pyproject-hooks #601

wants to merge 4 commits into from

Conversation

layday
Copy link
Member

@layday layday commented Apr 8, 2023

No description provided.

@layday layday mentioned this pull request Apr 8, 2023
Merged
henryiii
henryiii reviewed Apr 8, 2023
View reviewed changes
src/build/__init__.py Outdated
cwd: str | None = None,
extra_environ: Mapping[str, str] | None = None,
) -> None:
...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set ... as uncoverable in coverage's config.

henryiii
henryiii reviewed Apr 8, 2023
View reviewed changes
src/build/_util.py

from collections.abc import Iterator, Set

if sys.version_info >= (3, 8):
from typing import Protocol as Protocol
elif typing.TYPE_CHECKING:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too

@pradyunsg
Copy link
Member

Consider using from pyproject_hooks import SubprocessRunner behind a TYPE_CHECKING conditional instead of redefining the protocol.

@layday
Copy link
Member Author

layday commented Apr 8, 2023

Consider using from pyproject_hooks import SubprocessRunner behind a TYPE_CHECKING conditional instead of redefining the protocol.

SubprocessRunner is not public :)

@layday
Copy link
Member Author

layday commented Apr 8, 2023

All of our other types are also available at runtime, so it'd be odd for this one not to be.

@pradyunsg
Copy link
Member

Look at the PR again. ;)

@gaborbernat
Copy link
Contributor

Seems it stalled, @layday let me know if you want to pick it up again and we can reopen.

@gaborbernat gaborbernat closed this Feb 1, 2024
@layday
Copy link
Member Author

layday commented Feb 1, 2024

This was in draft until a version of pyproject-hooks is released with type hints, which hasn't happened yet.

@layday layday deleted the fix-runner-type branch March 1, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii left review comments

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

@gaborbernat gaborbernat Awaiting requested review from gaborbernat gaborbernat will be requested when the pull request is marked ready for review gaborbernat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@layday @pradyunsg @gaborbernat @henryiii