fix: pip config options were broken #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
joerick
reviewed
Mar 10, 2023
cibuildwheel/util.py
Outdated
| @@ -208,9 +208,10 @@ def get_build_verbosity_extra_flags(level: int) -> list[str]: | |||
| return [] | |||
|
|
|||
|
|
|||
| def split_config_settings(config_settings: str) -> list[str]: | |||
| def split_config_settings(config_settings: str, *, plural: bool) -> list[str]: | |||
There was a problem hiding this comment.
the 'plural' argument here is a little odd... Do you think it would be better to pass in the build backend instead (build or pip) and use that to decide the option name?
There was a problem hiding this comment.
I started that way, but then went this way as I thought it was a little nicer than passing a string around. But I don't have a strong preference. If a third backend was added someday, I guess mypy would force handling the extra literal. I'd hope this goes away in the future when we can rely on the (not yet released) next version of pip, which supports -C, like build.
Edit: I think either way is fine, so I changed it.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1429. Only "build" backend supported config options, since pip uses a different name (with an s).