feat: use manylinux-interpreters tool if present #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow dropping some EOL (and maybe some none EOL) python interpreters in manylinux images which would allow to reduce its size (faster for a vast majority of user, a small slow-down for users of those interpreters).
henryiii
reviewed
Oct 3, 2023
| @@ -117,10 +117,20 @@ def check_all_python_exist( | |||
| *, platform_configs: Iterable[PythonConfiguration], container: OCIContainer | |||
| ) -> None: | |||
| exist = True | |||
| has_manylinux_interpreters = True | |||
There was a problem hiding this comment.
Suggested change
| has_manylinux_interpreters = True | |
| has_manylinux_interpreters = False |
Comment on lines
+123
to
+127
| try: | ||
| # use capture_output to keep quiet | ||
| container.call(["manylinux-interpreters", "--help"], capture_output=True) | ||
| except subprocess.CalledProcessError: | ||
| has_manylinux_interpreters = False |
There was a problem hiding this comment.
Suggested change
| try: | |
| # use capture_output to keep quiet | |
| container.call(["manylinux-interpreters", "--help"], capture_output=True) | |
| except subprocess.CalledProcessError: | |
| has_manylinux_interpreters = False | |
| with contextlib.suppress(subprocess.CalledProcessError): | |
| # use capture_output to keep quiet | |
| container.call(["manylinux-interpreters", "--help"], capture_output=True) | |
| has_manylinux_interpreters = True |
(also add contextlib import above)
henryiii
approved these changes
Oct 3, 2023
joerick
approved these changes
Oct 3, 2023
mayeut
added a commit
to mayeut/cibuildwheel
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow dropping some EOL (and maybe some none EOL) python interpreters in manylinux images which would allow to reduce its size (faster for a vast majority of user, a small slow-down for users of those interpreters).
Updates to keep tests times down are not here yet, this is just to get things started.