Add option to specify pip versions on windows #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the initial setup for an environment on windows: 'python -m pip install --upgrade pip' is run unconditionally. However, there are situtations where a specific version of pip is needed (normally to avoid issues introduced in new pip releases). This commit adds a new config env variable flag, CIBW_PIP_VERSION_WINDOWS, which takes a pip version in that will be used for this command. For example, if CIBW_PIP_VERSION_WINDOWS=19.3.1 then the windows environment setup will run 'python -m pip install --upgrade pip=19.3.1'. Fixes pypa#250
|
On an initial look, this is quite specific. Why ónly Windows, and ónly |
|
Thanks for this @mtreinish ! I'm working on something that achieves this more generally in #256, so closing this in favour of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the initial setup for an environment on windows:
'python -m pip install --upgrade pip' is run unconditionally. However,
there are situtations where a specific version of pip is needed
(normally to avoid issues introduced in new pip releases). This commit
adds a new config env variable flag, CIBW_PIP_VERSION_WINDOWS, which
takes a pip version in that will be used for this command. For example,
if CIBW_PIP_VERSION_WINDOWS=19.3.1 then the windows environment setup
will run 'python -m pip install --upgrade pip=19.3.1'.
Fixes #250