fix: set MACOSX_DEPLOYMENT_TARGET for BEFORE_ALL #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebasing this as well, since CircleCI is still broken. |
YannickJadoul
force-pushed
the
fix/macos_dep_all
branch
from
a9c499f to
5c5f439
Compare
YannickJadoul
approved these changes
Feb 11, 2021
|
@henryiii, Azure is a bit confused, but depending on how much you are in a hurry, this could get merged, I think :-) |
joerick
approved these changes
Feb 12, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at it, I think just a simple fix is likely okay; there's not a way to combine these easily, and it's a bit specific to this one variable. Fixes #563.