Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.7 #73

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Add support for Python 3.7 #73

merged 4 commits into from
Jun 18, 2018

Conversation

lelit
Copy link
Contributor

@lelit lelit commented Jun 16, 2018

This enables building binary wheels for Python 3.7, now at its rc1 release.

It is included in the latest manylinux1 Docker image, see pypa/manylinux#196.

Accordingly to https://www.appveyor.com/docs/build-environment/#python it is not yet available on Appveyor.

lelit added 2 commits June 16, 2018 13:42
This enables building binary wheels for Python 3.7, now at its rc1 release.

It is included in the latest manylinux1 Docker image, see pypa/manylinux#196.

Accordingly to https://www.appveyor.com/docs/build-environment/#python it is not yet available on Appveyor.
@lelit
Copy link
Contributor Author

lelit commented Jun 16, 2018

It fails, because the dockcross/manylinux1 images do not carry py37 yet.

@joerick
Copy link
Contributor

joerick commented Jun 17, 2018

awesome work @lelit! any idea when the dockcross image will be published?

@lelit
Copy link
Contributor Author

lelit commented Jun 18, 2018

No, unfortunately they pushed an update just before the standard manylinux1 gained support for 3.7, and from https://hub.docker.com/r/dockcross/manylinux-x64/tags/ it's not clear how often that happens.

@YannickJadoul
Copy link
Member

YannickJadoul commented Jun 18, 2018

Nice! :-)
Is this urgent to include (given that AppVeyor still doesn't have it either), or could we wait 1 or 2 more weeks for the full release (cfr. https://www.python.org/dev/peps/pep-0537/)?

EDIT: Personally, I don't care about dockcross that much, to be fair. It's mainly meant to test the alternative docker image option, so we can just temporarily disable that test, as far as I'm concerned.

@hroncok
Copy link
Contributor

hroncok commented Jun 18, 2018

Is this urgent to include (given that AppVeyor still doesn't have it either), or could we wait 1 or 2 more weeks for the full release

Please, release this. Getting 3.7 builds building at rc1 stage means we can find more 3.7 bugs before the actual release.

@YannickJadoul
Copy link
Member

Please, release this.

Fair enough. Let's just temporarily disable that one test, then?

@lelit
Copy link
Contributor Author

lelit commented Jun 18, 2018 via email

@YannickJadoul
Copy link
Member

Myeah, but wouldn't you want to know by having that as an error and manually disabling that version for that build, instead of silently ignoring what could be a potential oversight?

@lelit
Copy link
Contributor Author

lelit commented Jun 18, 2018

Possibly yes... I was just thinking aloud (I do not use alternative manylinuxXX images myself): the question is about whether it should be always an hard error or if it could be downgraded (by default, or with an option) to a warning message instead.

@YannickJadoul
Copy link
Member

Yes, no, sorry, didn't mean to shut that suggestion down completely, but just my 2 cents on that. Since CIBW_SKIP (and e.g. cp37-manylinux*) is so easy, I thought there's maybe something to say for "explicit is better than implicit"?

We'll reenable this when 3.7 is released and dockcross updates :)
@joerick
Copy link
Contributor

joerick commented Jun 18, 2018

Yeah, let's just disable that test on Python 3.7 for now then :)

@joerick
Copy link
Contributor

joerick commented Jun 18, 2018

The 06_docker_images test is really just there to check that the CIBW_MANYLINUX1_XXX_IMAGE options are honored, it's up to the user to create a valid config.

@joerick joerick merged commit 33433f0 into pypa:master Jun 18, 2018
@joerick
Copy link
Contributor

joerick commented Jun 18, 2018

Released as 0.9.0!

@hroncok
Copy link
Contributor

hroncok commented Jun 18, 2018

Thank You!

@lelit
Copy link
Contributor Author

lelit commented Jun 19, 2018

Great, many thanks!

@lelit lelit deleted the py37 branch June 19, 2018 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants