#219 Use sysconfig.get_config_h_filename() to locate pyconfig.h

[zooba]

I've used the minimal change here. It would be totally valid to always make this call and only add the path if it differs from {prefix}\include, but it still only affects the case where we're in a CPython build directory so I don't see any reason to touch code outside of the checks for that.

Fixes #219

[zooba]

Those failures seem to be due to setuptools not being installed by default in 3.12. I'd suggest that may indicate that earlier versions are testing the wrong distutils/setuptools versions, or at least missing the opportunity to test with the current code.

The tests impacted by this change passed. It's unfortunate that it aborts the parallel jobs so we can't see their results.

[lazka]

lgtm, but there is one more place where the old path is used:

distutils/distutils/sysconfig.py

Lines 362 to 371 in 35069ad

	def get_config_h_filename():
	"""Return full pathname of installed pyconfig.h file."""
	if python_build:
	if os.name == "nt":
	inc_dir = os.path.join(_sys_home or project_base, "PC")
	else:
	inc_dir = _sys_home or project_base
	return os.path.join(inc_dir, 'pyconfig.h')
	else:
	return sysconfig.get_config_h_filename()

[lazka]

The tests impacted by this change passed. It's unfortunate that it aborts the parallel jobs so we can't see their results.

I've created #222 for this

[zooba]

there is one more place where the old path is used

Is there any reason why this shouldn't just call sysconfig all the time? (Or just import the function from sysconfig instead of redefining it?)

[lazka]

Not to my knowledge. I skipped the build-python part in 676e669 back then because I wasn't sure if the logic was equal after things diverged with CPython and I didn't want to risk it.

[lazka]

lgtm

[zooba]

@jaraco Are you still merging stuff for this project? You'll want this change before 3.13 ships :)

[zooba]

Ping on this issue.

[zooba]

Thanks Jason!