Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cygwinccompiler: Get the compilers from sysconfig #296

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

naveen521kk
Copy link
Contributor

On the CLANG64 environment of MSYS2, we should use clang
instead of gcc. This patch gets the compiler from sysconfig which
would be set when Python was built.

Without this patch, the build fails when it's trying to check if the
compiler is cygwin's one.

On the CLANG64 environment of MSYS2, we should use clang
instead of gcc. This patch gets the compiler from sysconfig which
would be set when Python was built.

Without this patch, the build fails when it's trying to check if the
compiler is cygwin's one.
@lazka
Copy link
Contributor

lazka commented Sep 12, 2024

lgtm

(There is potential for moving all this to customize_compiler() but we would have to somehow get rid of is_cygwincc(), or only call it when actually using the compiler, as it is currently expects the compiler to be set before customize_compiler(). Not clear, so let's keep the fix simple)

@jaraco jaraco merged commit 7283751 into pypa:main Sep 15, 2024
21 checks passed
@naveen521kk naveen521kk deleted the clang-compilers branch September 15, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants